fix: make types strict to prevent accidental deletion via unused types, the optionality is a trap, they are required #16346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
requested review from
mroz22,
szymonlesisz,
martykan and
marekrjpolak
as code owners
peter-sanderson
commented
Jan 14, 2025
| received?: string; | ||
| balance: string; | ||
| sent: string; | ||
| received: string; |
There was a problem hiding this comment.
By making it required we avoid the trap of unused values.
Those are used and required and IMO the only reason they were optional is some back compatibility or iterative composition of the type.
The "0" value can be used safely I think as we turn it to 0 anyway in the UI.
|
🚀 Expo preview is ready!
|
peter-sanderson
force-pushed
the
fix-stuff-zero-stuff2
branch
2 times, most recently
from
4ad2055 to
cd56b6f
Compare
…s, the optionality is a trap, they are required
peter-sanderson
force-pushed
the
fix-stuff-zero-stuff2
branch
from
cd56b6f to
610bbf2
Compare
martykan
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of #16340
Followup of #16344